Skip to content

GH-49248: [Release] Include checksum in vote email#49249

Merged
kou merged 18 commits intoapache:mainfrom
amoeba:release/gh-49248--checksum-in-vote-thread
Feb 17, 2026
Merged

GH-49248: [Release] Include checksum in vote email#49249
kou merged 18 commits intoapache:mainfrom
amoeba:release/gh-49248--checksum-in-vote-thread

Conversation

@amoeba
Copy link
Member

@amoeba amoeba commented Feb 11, 2026 •
edited by github-actions bot
Loading

Rationale for this change

Resolves #49248

What changes are included in this PR?

Adds a step to the SOURCE_VOTE step in 02-source.sh to grab the checksum we just pushed to svn from dist.apache.org and include that checksum as a footnote in the vote thread email. I did it this way because the person running this script may run this script like,

SOURCE_DEFAULT=0 SOURCE_VOTE=1 dev/release/02-source.sh 23.0.1 0

So the only way to get the checksum at this point is with another SVN command or by downloading the file from dist.apache.org.

Are these changes tested?

Yes, using currently active RC and with the above command.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the awaiting review Awaiting review label Feb 11, 2026
@amoeba
Copy link
Member Author

amoeba commented Feb 12, 2026

@raulcd this is ready for a review. I opted to put the checksum as a footnote since it's >80 chars and I didn't think it would look good if it was in the main text. Happy to do something else.

@amoeba amoeba mentioned this pull request Feb 12, 2026
Merged
kou
kou reviewed Feb 12, 2026
View reviewed changes
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Feb 12, 2026
@amoeba @kou
Update dev/release/02-source.sh
255c034 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 12, 2026
@amoeba amoeba requested a review from kou February 12, 2026 21:06
kou
kou approved these changes Feb 17, 2026
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting review Awaiting review awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Feb 17, 2026
kou
kou reviewed Feb 17, 2026
View reviewed changes
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review awaiting merge Awaiting merge labels Feb 17, 2026
amoeba and others added 2 commits February 16, 2026 17:49
@amoeba @kou
Update dev/release/02-source-test.rb
0ce46cc 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@amoeba @kou
Update dev/release/02-source-test.rb
fbebf51 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 17, 2026
amoeba and others added 3 commits February 16, 2026 17:50
@amoeba @kou
Update dev/release/02-source.sh
3de13e2 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@amoeba
fix typo
3adfff3
@amoeba
move requrie
96fd0b1
@amoeba amoeba requested a review from kou February 17, 2026 02:00
@amoeba
Copy link
Member Author

amoeba commented Feb 17, 2026

Thanks @kou. Suggestions accepted and one extra fix made.

@kou kou merged commit 76f7815 into apache:main Feb 17, 2026
9 checks passed
@kou kou removed the awaiting change review Awaiting change review label Feb 17, 2026
@kou kou mentioned this pull request Feb 17, 2026
Closed
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Feb 18, 2026

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 76f7815.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them.

@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Feb 20, 2026

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 76f7815.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

@kou kou Awaiting requested review from kou kou is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Release] Update vote thread email template to include checkum

2 participants

@amoeba @kou